Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve event types single page loading speed #9792

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

G3root
Copy link
Contributor

@G3root G3root commented Jun 26, 2023

What does this PR do?

Fixes #9786

  • lazy loaded tabs
  • lazy loaded managed event type dialog

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Test A
  • Test B

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api 🔄 Building (Inspect) Mar 19, 2024 3:21pm
cal 🔄 Building (Inspect) Mar 19, 2024 3:21pm
dev ❌ Failed (Inspect) Mar 19, 2024 3:21pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:21pm
web-staging ❌ Failed (Inspect) Mar 19, 2024 3:21pm

@vercel
Copy link

vercel bot commented Jun 26, 2023

@G3root is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jun 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 284.12 KB 437.5 KB 125.00% (🟡 +0.31%)
/apps/[slug] 302.12 KB 455.5 KB 130.14% (🟡 +0.32%)
/apps/[slug]/[...pages] 438.48 KB 591.85 KB 169.10% (🟡 +0.35%)
/apps/categories 264.1 KB 417.47 KB 119.28% (🟡 +0.31%)
/apps/categories/[category] 267.36 KB 420.74 KB 120.21% (🟡 +0.32%)
/availability 269.63 KB 423.01 KB 120.86% (🟡 +0.31%)
/availability/[schedule] 355.54 KB 508.92 KB 145.41% (🟡 +0.30%)
/availability/troubleshoot 264.83 KB 418.21 KB 119.49% (🟡 +0.31%)
/bookings/[status] 352.39 KB 505.77 KB 144.51% (🟡 +0.32%)
/event-types 446.25 KB 599.63 KB 171.32% (🟡 +0.46%)
/event-types/[type] 296.11 KB 449.49 KB 128.43% (🟢 -57.07%)
/getting-started/[[...step]] 420.09 KB 573.47 KB 163.85% (🟢 -0.23%)
/insights 471.26 KB 624.64 KB 178.47% (🟡 +0.31%)
/more 263.73 KB 417.1 KB 119.17% (🟡 +0.32%)
/settings/admin 269.55 KB 422.93 KB 120.84% (🟡 +0.31%)
/settings/admin/apps 280.04 KB 433.42 KB 123.83% (🟡 +0.34%)
/settings/admin/apps/[category] 280 KB 433.37 KB 123.82% (🟡 +0.33%)
/settings/admin/flags 272.34 KB 425.72 KB 121.63% (🟡 +0.32%)
/settings/admin/impersonation 269.83 KB 423.21 KB 120.92% (🟡 +0.31%)
/settings/admin/users 270.97 KB 424.35 KB 121.24% (🟡 +0.32%)
/settings/admin/users/[id]/edit 351.13 KB 504.51 KB 144.15% (🟡 +0.31%)
/settings/admin/users/add 350.81 KB 504.19 KB 144.05% (🟡 +0.32%)
/settings/billing 269.71 KB 423.09 KB 120.88% (🟡 +0.32%)
/settings/developer/api-keys 298.27 KB 451.65 KB 129.04% (🟡 +0.32%)
/settings/developer/webhooks 273 KB 426.38 KB 121.82% (🟡 +0.32%)
/settings/developer/webhooks/[id] 274.4 KB 427.78 KB 122.22% (🟡 +0.30%)
/settings/developer/webhooks/new 274.25 KB 427.63 KB 122.18% (🟡 +0.30%)
/settings/my-account/appearance 284.86 KB 438.24 KB 125.21% (🟡 +0.30%)
/settings/my-account/conferencing 275.42 KB 428.8 KB 122.52% (🟡 +0.31%)
/settings/my-account/general 354.55 KB 507.93 KB 145.12% (🟡 +0.32%)
/settings/my-account/profile 397.64 KB 551.02 KB 157.43% (🟡 +0.32%)
/settings/organizations/appearance 282.05 KB 435.42 KB 124.41% (🟡 +0.25%)
/settings/organizations/general 350.16 KB 503.54 KB 143.87% (🟡 +0.31%)
/settings/organizations/members 381.5 KB 534.88 KB 152.82% (🟡 +0.32%)
/settings/organizations/profile 392.17 KB 545.55 KB 155.87% (🟡 +0.32%)
/settings/security/impersonation 271.51 KB 424.88 KB 121.40% (🟡 +0.31%)
/settings/security/password 274.72 KB 428.1 KB 122.31% (🟡 +0.32%)
/settings/security/sso 278.99 KB 432.37 KB 123.53% (🟡 +0.32%)
/settings/security/two-factor-auth 273.93 KB 427.3 KB 122.09% (🟡 +0.31%)
/settings/teams 269.32 KB 422.7 KB 120.77% (🟡 +0.32%)
/settings/teams/[id]/appearance 282.05 KB 435.43 KB 124.41% (🟡 +0.25%)
/settings/teams/[id]/billing 269.56 KB 422.94 KB 120.84% (🟡 +0.31%)
/settings/teams/[id]/members 383.78 KB 537.16 KB 153.47% (🟡 +0.32%)
/settings/teams/[id]/onboard-members 177.76 KB 331.13 KB 94.61% (🟡 +0.24%)
/settings/teams/[id]/profile 460.57 KB 613.95 KB 175.41% (🟡 +0.17%)
/settings/teams/[id]/sso 279.08 KB 432.46 KB 123.56% (🟡 +0.32%)
/settings/teams/new 217.39 KB 370.77 KB 105.93% (🟡 +0.32%)
/teams 263.81 KB 417.19 KB 119.20% (🟡 +0.31%)
/workflows 276.11 KB 429.49 KB 122.71% (🟡 +0.32%)
/workflows/[workflow] 385.37 KB 538.75 KB 153.93% (🟡 +0.43%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich requested a review from a team June 28, 2023 16:38
@PeerRich
Copy link
Member

great solution!

@PeerRich PeerRich added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Jun 28, 2023
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars enabled auto-merge (squash) June 28, 2023 19:43
@zomars zomars merged commit 3b1cca2 into calcom:main Jun 28, 2023
25 of 28 checks passed
@G3root G3root deleted the perf/event-types-page branch June 28, 2023 19:44
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2046] speed up tabs of event-types
3 participants