fix: Allow editing guests when rescheduling or editing a booking #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jemiluv8 is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
bookings
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
jemiluv8
changed the title
…ndees to the "rescheduled" booking to ensure that guests added or removed are used for the "rescheduled" booking
|
@alannnc, I've completed the self review. |
shivamklr
previously approved these changes
Jul 7, 2023
shivamklr
requested review from
shivamklr
and removed request for
a team and
alannnc
…uest-when-rescheduling-event
|
Merge conflicts resolved. |
shivamklr
approved these changes
Jul 12, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
…com#9878) * Allow editing guests when rescheduling or editing * lint fix * modify reschedule logic that assigned originalRescheduledBooking.attendees to the "rescheduled" booking to ensure that guests added or removed are used for the "rescheduled" booking --------- Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows users to add/remove from the gusts list when rescheduling a booking
Fixes #9167
/claim #9167
Editing Guests
https://www.loom.com/share/318584ebf2b44745a10867955a5484e8?sid=68ee2b32-9e64-4813-8587-90e13ca4dec2
Viewing New Booking Success Screen - To confirm edited guests
https://www.loom.com/share/e27797530e044f39a87bfdbf43d2adc4
Type of change
How should this be tested?
Mandatory Tasks
Checklist
I haven't read the contributing guideMy code doesn't follow the style guidelines of this projectI haven't commented my code, particularly in hard-to-understand areasI haven't checked if my PR needs changes to the documentationI haven't checked if my changes generate no new warningsI haven't added tests that prove my fix is effective or that my feature worksI haven't checked if new and existing unit tests pass locally with my changes