Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace slack with discord #9900

Merged
merged 9 commits into from
Jul 4, 2023
Merged

chore: replace slack with discord #9900

merged 9 commits into from
Jul 4, 2023

Conversation

shawshankkumar
Copy link
Contributor

What does this PR do?

Since the community moves from slack to discord (wohhooo! btw), I thought I would make a pr and start working on changing all slack redirections to discord.
This might not be complete, still working on

  1. The discord icon (need to replace the slack one)
  2. A few translations might need correction

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Preview url

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 3, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 10:09pm
ui ❌ Failed (Inspect) Jul 4, 2023 10:09pm

@vercel
Copy link

vercel bot commented Jul 3, 2023

@shawshankkumar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023 •
edited

Thank you for following the naming conventions! 🙏

@shawshankkumar shawshankkumar changed the title [WIP] chore: replace slack with discord chore: replace slack with discord Jul 3, 2023
@shawshankkumar shawshankkumar marked this pull request as ready for review July 3, 2023 19:54
@shawshankkumar
Copy link
Contributor Author

Before its ready to merge, I need some help on updating the slack icon to the discord icon on the 404 page.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich
Copy link
Member

PeerRich commented Jul 4, 2023

very thoughtful of you!

@shawshankkumar
Copy link
Contributor Author

very thoughtful of you!

I have been trying to contribute in a meaningful way for a long time but most of the times someone else beats me to it haha. So I though this would be a good start. I had a few other ideas, I'll make draft prs then link them to issues if that's fine?

PeerRich
PeerRich reviewed Jul 4, 2023
View reviewed changes
packages/lib/constants.ts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jul 4, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

PeerRich
PeerRich previously approved these changes Jul 4, 2023
View reviewed changes
@shawshankkumar
Copy link
Contributor Author

image

@PeerRich Does this look fine? I have added a new commit.

@PeerRich
Copy link
Member

PeerRich commented Jul 4, 2023

image @PeerRich Does this look fine? I have added a new commit.

make sure to use tailwind to tint the SVG in the correct color, also test on light mode.

give the SVG fill="currentColor" so it adopts whatever the container color is

@shawshankkumar
Copy link
Contributor Author

Yes @PeerRich my bad sorry, i forgot light mode even existed.
I shifted the SVG to the codebase instead of loading via an img tag for better customisation. I took reference from the code base. Also ideally shouldn't we have a helper kinda thing to load all svgs?

here are screenshots:
image

another:
image

@PeerRich
Copy link
Member

PeerRich commented Jul 4, 2023

terrific!

@PeerRich PeerRich enabled auto-merge (squash) July 4, 2023 22:06
@PeerRich PeerRich merged commit 6bd9706 into calcom:main Jul 4, 2023
24 of 27 checks passed
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@shawshankkumar @PeerRich @fritterhoff
chore: replace slack with discord (calcom#9900)
d5042c6 
* chore: replace slack with discord

* fix: add slack again to avoid braking code

* chore: update readme.md

* chore: update 404

* Update packages/lib/constants.ts

* chore: add discord svg and update 404

* chore: delete svg and shift to code

---------

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Peer Richelsen <peer@cal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawshankkumar @PeerRich