Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing Video Apps #9927

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: Missing Video Apps #9927

merged 1 commit into from
Jul 4, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jul 4, 2023

What does this PR do?

Fixes missing video apps. Happened because "conferencing" was a reserved group name already by 'Host's Default conferencing app'(which is shown only for Team Events) and all existing apps got recategorized to the same 'Conferencing' name.

  • Bug fix (non-breaking change which fixes an issue)

Team Event
image

User Event
Screenshot 2023-07-05 at 12 30 31 AM
image

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Mar 19, 2024 2:42pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:42pm
ui ❌ Failed (Inspect) Mar 19, 2024 2:42pm
web-staging 🔄 Building (Inspect) Mar 19, 2024 2:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Mar 19, 2024 2:42pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars enabled auto-merge (squash) July 4, 2023 19:04
}
return {
...option,
options: option.options.filter((o) => o.value !== OrganizerDefaultConferencingAppType),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an alternate way to identify Default Conferencing App. Now All Video apps and Host's Default Conferencing app would come under Conferencing only.
User Events would just filter out 'Host's default App' option identified by OrganizerDefaultConferencingAppType

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Jul 4, 2023

Current Playwright Test Results Summary

✅ 125 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/04/2023 07:09:45pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f1ced48

Started: 07/04/2023 07:08:04pm UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
2.45% (4) 4 / 163 runs
failed over last 7 days
33.13% (54) 54 / 163 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars merged commit 08683a4 into main Jul 4, 2023
28 of 31 checks passed
@zomars zomars deleted the hotfix/missing-video-apps branch July 4, 2023 19:10
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants