-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing Video Apps #9927
fix: Missing Video Apps #9927
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Thank you for following the naming conventions! 🙏 |
741dc06
to
f1ced48
Compare
} | ||
return { | ||
...option, | ||
options: option.options.filter((o) => o.value !== OrganizerDefaultConferencingAppType), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an alternate way to identify Default Conferencing App. Now All Video apps and Host's Default Conferencing app would come under Conferencing only.
User Events would just filter out 'Host's default App' option identified by OrganizerDefaultConferencingAppType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @emrysal
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 125 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/04/2023 07:09:45pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f1ced48 Started: 07/04/2023 07:08:04pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
2.45% (4)4 / 163 runsfailed over last 7 days |
33.13% (54)54 / 163 runsflaked over last 7 days |
What does this PR do?
Fixes missing video apps. Happened because "conferencing" was a reserved group name already by 'Host's Default conferencing app'(which is shown only for Team Events) and all existing apps got recategorized to the same 'Conferencing' name.
Team Event
User Event