Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/linear comment images sync #161

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

rockingrohit9639
Copy link
Collaborator

Summary

Images from the linear comments does not appear on github.

Test Plan

Tested it on my repository

image

Related Issues

Fixes #138

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
synclinear ✅ Ready (Inspect) Visit Preview Mar 11, 2024 3:51pm

// Re-fetching the comment returns it with public image URLs
if (modifiedBody?.match(GENERAL.INLINE_IMG_TAG_REGEX)) {
const publicComment = await linear.comment(data.id);
modifiedBody = publicComment.body;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean change!

Copy link
Collaborator

@tedspare tedspare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedspare tedspare merged commit 4ebfa14 into main Mar 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear-made comments with images do not show up on GitHub comments
2 participants