Merge branch 'master' into weather

* master:
  Some fixes for nullable user parameters.
  Allow anonymous users.
  Allow null values for $user parameter.

src/AppBundle/Security/Authorization/Voter/AbstractVoter.php

@@ -12,13 +12,15 @@ protected function voteOnAttribute($attribute, $subject, TokenInterface $token):
     {
         $user = $token->getUser();
 
-        if (!$user instanceof User) {
-            return false;
-        }
-
         $canMethodName = $this->getCanMethodName($attribute);
 
-        return $this->$canMethodName($subject, $user);
+        if ($this->isUserMandatory($canMethodName) && !$user instanceof User) {
+            return false;
+        } elseif (!$this->isUserMandatory($canMethodName) && !$user instanceof User) {
+            return $this->$canMethodName($subject, null, $user);
+        } else {
+            return $this->$canMethodName($subject, $user);
+        }
     }
 
     protected function supports($attribute, $subject): bool
@@ -70,4 +72,22 @@ protected function getCanMethodName(string $attribute): string
     {
         return sprintf('can%s', ucfirst(strtolower($attribute)));
     }
+
+    protected function isUserMandatory(string $methodName): bool
+    {
+        $reflection = new \ReflectionMethod($this, $methodName);
+        $parameters = $reflection->getParameters();
+
+        if (count($parameters) <= 2) {
+            return true;
+        }
+
+        $userParameter = $parameters[1];
+
+        if ($userParameter->getClass()->getName() === User::class) {
+            return !$userParameter->allowsNull();
+        }
+
+        throw new \InvalidArgumentException('There must be a User accepting parameter');
+    }
 }

src/AppBundle/Security/Authorization/Voter/PhotoVoter.php

@@ -7,7 +7,7 @@
 
 class PhotoVoter extends AbstractVoter
 {
-    protected function canView(Photo $photo, User $user): bool
+    protected function canView(Photo $photo, User $user = null, string $username = null): bool
     {
         return true;
     }