Aho-Corasick #167
Merged
Aho-Corasick #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotwrobson
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Just rebased with a new docstring, everything looks good! Will merge soon.
@Tagl I wound up getting rid of the from_suffixes function, just because the API for this class is getting a little bloated, and that function was only a passthrough for the new functionality here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
@caleb531 @eliotwrobson
Haven't added tests for full coverage but I've done a fair bit of manual testing and it is producing correct results.
The DFA produced isn't necessarily minimal (consider {"ab", "abba"}) but it's certainly faster than taking multiple unions.
I've been trying to cut it down to a single BFS and then remove the object oriented nodes but there's always something that just isn't clicking for me, so I'm keeping it like this for now, maybe you will spot it.
I have to put this on hold on my end for a few days.