Fix issue with minimization of partial DFAs #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing to remake later. Nothing wrong with the approach here, but I think that there's a way of doing this that handles edge cases more cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title, resolves #182. I think this was caused by issues related to running the minimization algorithm on partial DFAs. This changes the API slightly, but should resolve those issues. Still a draft because docs changes are needed. Slight decrease in efficiency but I think this isn't going to affect very many people. We should be able to change things back somewhat once #161 gets merged and we have an algorithm specifically written for partial DFAs.
cc @martinec