fix: Small changes from comment #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleb531
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
@eliotwrobson I read Leah's comment from the review thread, and this makes sense to me! It's also nice to know some of these practices are no longer necessary.
Approved!
|
@eliotwrobson BTW, feel free to merge these housekeeping changes into |
|
@eliotwrobson But maybe first double-check that there aren't any other code changes that might be inadvertently merged in. |
|
@caleb531 merged to main! The only new commit was the one generated from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes suggested by this comment from the review: pyOpenSci/software-submission#152 (comment)
Ran the build command locally and seems to work? Not 1000% sure if I tested this correctly, but I think fairly reasonable changes.