Not able to chain calls to removeLayer using v5.4

[BillyRayPreachersSon]

It seems that when using v5.4, you can'tt chain calls to removeLayer. Here's my test code from Issue #18:

var MyObj = {
    canvas: $('<canvas />'),

    addLayer: function() {
        this.canvas.addLayer(this.drawLines);
    },

    drawLines: function lines(ctx) {
        console.log('MyObj.drawLines is being called');
        console.log('"this" context = ', this);
    }
}

Here's what I see when using v5.3.1:

MyObj.canvas.addLayer({ method:'drawRect', name:'myBox', fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.addLayer({ method:'drawRect', name:'myBox2', fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.getLayers().length;                            // 2
MyObj.canvas.getLayer('myBox');                             // Object
MyObj.canvas.getLayer('myBox2');                            // Object
MyObj.canvas.removeLayer('myBox').removeLayer('myBox2');    // [<canvas>​]
MyObj.canvas.getLayers().length;                            // 0

And with v5.4:

MyObj.canvas.addLayer({ method:'drawRect', name:'myBox', fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.addLayer({ method:'drawRect', name:'myBox2', fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.getLayers().length;                            // 2
MyObj.canvas.getLayer('myBox');                             // E
MyObj.canvas.getLayer('myBox2');                            // E
MyObj.canvas.removeLayer('myBox').removeLayer('myBox2');    // TypeError: Cannot call method 'removeLayer' of undefined

I'd initially thought it was failing as no layer existed with the name I was trying to remove - but it happens when removing layers that are present as well.

Dan

[caleb531]

Wow, how did I miss that? :/

Anyway, it's fixed now. The fixed build should already be on GitHub.

-Caleb

On Sat, Jun 9, 2012 at 7:56 AM, BillyRayPreachersSon <
reply@reply.github.com

wrote:

It seems that when using v5.4, you can'tt chain calls to removeLayer.
Here's my test code from Issue #18:

var MyObj = {
       canvas: $('<canvas />'),

       addLayer: function() {
               this.canvas.addLayer(this.drawLines);
       },

       drawLines: function lines(ctx) {
               console.log('MyObj.drawLines is being called');
               console.log('"this" context = ', this);
       }
}

Here's what I see when using v5.3.1:

MyObj.canvas.addLayer({ method:'drawRect', name:'myBox', fillStyle:'#585',
x:100, y:100, width:100, height:50 });
MyObj.canvas.addLayer({ method:'drawRect', name:'myBox2',
fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.getLayers().length;
             // 2
MyObj.canvas.getLayer('myBox');
              // Object
MyObj.canvas.getLayer('myBox2');
             // Object
MyObj.canvas.removeLayer('myBox').removeLayer('myBox2');        //
[<canvas>​]
MyObj.canvas.getLayers().length;
             // 0

And with v5.4:

MyObj.canvas.addLayer({ method:'drawRect', name:'myBox', fillStyle:'#585',
x:100, y:100, width:100, height:50 });
MyObj.canvas.addLayer({ method:'drawRect', name:'myBox2',
fillStyle:'#585', x:100, y:100, width:100, height:50 });
MyObj.canvas.getLayers().length;
             // 2
MyObj.canvas.getLayer('myBox');
              // E
MyObj.canvas.getLayer('myBox2');
             // E
MyObj.canvas.removeLayer('myBox').removeLayer('myBox2');        //
TypeError: Cannot call method 'removeLayer' of undefined

I'd initially thought it was failing as no layer existed with the name I
was trying to remove - but it happens when removing layers that are present
as well.

Dan

---

Reply to this email directly or view it on GitHub:
#19