Skip to content

Commit

Permalink
Next Major (#197)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Updates dependencies which add rules
  • Loading branch information
calebeby committed May 11, 2020
1 parent cdd6889 commit 82b778b
Show file tree
Hide file tree
Showing 10 changed files with 2,442 additions and 3,131 deletions.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist
23 changes: 11 additions & 12 deletions LICENSE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,19 @@ The MIT License (MIT)

Copyright 2018 Caleb Eby

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ The plugins that this exposes are:
- [`react-hooks`](https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks)

This also exposes a couple rules from
[`shopify`](https://github.com/shopify/eslint-plugin-shopify):
[`shopify`](https://github.com/Shopify/web-foundation/tree/master/packages/eslint-plugin):

- [`shopify/prefer-early-return`](https://github.com/Shopify/eslint-plugin-shopify/blob/master/docs/rules/prefer-early-return.md)
- [`shopify/prefer-class-properties`](https://github.com/Shopify/eslint-plugin-shopify/blob/master/docs/rules/prefer-class-properties.md)
- [`shopify/prefer-early-return`](https://github.com/Shopify/web-foundation/blob/master/packages/eslint-plugin/docs/rules/prefer-early-return.md)
- [`shopify/prefer-class-properties`](https://github.com/Shopify/web-foundation/blob/master/packages/eslint-plugin/docs/rules/prefer-class-properties.md)

To override settings for any of these plugins, you must prefix the configuration
with `caleb/`, because the plugins are exposed through this "super-plugin".
Expand All @@ -34,7 +34,7 @@ with `caleb/`, because the plugins are exposed through this "super-plugin".
"extends": ["plugin:calebeby/recommended"],
"rules": {
"caleb/unicorn/catch-error-name": "off",
"caleb/shopify/prefer-early-return": "off"
"caleb/@shopify/prefer-early-return": "off"
}
}
```
Expand Down
5 changes: 1 addition & 4 deletions babel.config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
module.exports = {
plugins: [
'@babel/plugin-transform-shorthand-properties', // this is needed for object function keys to be transpiled so objects get inlined with terser
[
'@babel/plugin-proposal-object-rest-spread',
{ loose: true, useBuiltIns: true },
],
'babel-plugin-un-cjs',
],
}
4 changes: 2 additions & 2 deletions build.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { configs, environments } = require('./src/config')

const resolveStart = '__REQUIRE_RESOLVE__'
const resolveEnd = '__END_REQUIRE_RESOLVE'
const stringify = data =>
const stringify = (data) =>
`module.exports = ${JSON.stringify(data, (k, v) => {
if (k === 'parser' && v.startsWith(__dirname)) {
return (
Expand All @@ -29,7 +29,7 @@ const stringify = data =>
},
)

const createFile = data =>
const createFile = (data) =>
prettier.format(stringify(data), {
parser: 'babel',
singleQuote: true,
Expand Down

0 comments on commit 82b778b

Please sign in to comment.