Skip to content

Commit

Permalink
V9
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Breaking updates to sub-plugins
  • Loading branch information
calebeby committed May 18, 2020
2 parents 9f76b64 + 2e0791f commit f212acc
Show file tree
Hide file tree
Showing 4 changed files with 66 additions and 132 deletions.
171 changes: 47 additions & 124 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 11 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
"dist"
],
"dependencies": {
"@typescript-eslint/eslint-plugin": "2.31.0",
"@typescript-eslint/parser": "2.31.0",
"@typescript-eslint/eslint-plugin": "2.33.0",
"@typescript-eslint/parser": "2.33.0",
"eslint-plugin-import": "2.20.2",
"eslint-plugin-jest": "23.10.0",
"eslint-plugin-jest": "23.13.1",
"eslint-plugin-jsx-a11y": "6.2.3",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-promise": "4.2.1",
"eslint-plugin-react": "7.19.0",
"eslint-plugin-react": "7.20.0",
"eslint-plugin-react-hooks": "4.0.0",
"eslint-plugin-standard": "4.0.1",
"eslint-plugin-unicorn": "19.0.1"
"eslint-plugin-unicorn": "20.0.0"
},
"devDependencies": {
"@babel/core": "7.9.6",
Expand All @@ -35,17 +35,17 @@
"@rollup/plugin-json": "4.0.3",
"@rollup/plugin-node-resolve": "7.1.3",
"@shopify/eslint-plugin": "36.1.0",
"babel-plugin-un-cjs": "1.3.0",
"babel-plugin-un-cjs": "2.0.0",
"eslint": "7.0.0",
"eslint-config-prettier": "6.11.0",
"eslint-config-standard": "14.1.1",
"eslint-config-xo": "0.29.1",
"prettier": "2.0.5",
"rollup": "2.9.1",
"rollup": "2.10.2",
"rollup-plugin-prettier": "2.0.0",
"rollup-plugin-terser": "5.3.0",
"semantic-release": "17.0.7",
"typescript": "3.8.3"
"typescript": "3.9.2"
},
"peerDependencies": {
"eslint": "^6 || ^7.0.0",
Expand All @@ -58,6 +58,9 @@
"proseWrap": "always"
},
"release": {
"branches": [
"master"
],
"plugins": [
[
"@semantic-release/commit-analyzer",
Expand Down
3 changes: 3 additions & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export default {
preferConst: true,
freeze: false,
},
treeshake: {
moduleSideEffects: false,
},
external,
plugins: [
nodeResolve({ extensions }),
Expand Down
5 changes: 5 additions & 0 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ module.exports.configs = {
'unicorn/no-null': 'off', // Null is ok, and can be used. DOM uses null a lot. This rule is really annoying
'unicorn/no-fn-reference-in-iterator': 'off', // The situation where this rule would trigger usefully is very very rare. It probably triggers useslessly at least 10x as often. This can be caught by manual code review
'unicorn/better-regex': ['error', { sortCharacterClasses: false }],
'unicorn/prefer-set-has': 'off', // Let humans decide correct data structure
'unicorn/consistent-function-scoping': 'off', // I like the idea of this rule, but it seems like it triggers too often in cases where the code is "correct"
'unicorn/no-useless-undefined': 'off', // Removing undefined can cause TS errors
'unicorn/no-reduce': 'off', // Reduce is often useful
'no-else-return': ['error', { allowElseIf: true }],
'no-await-in-loop': 'off', // Sometimes I want to await in a loop. I don't see why this is a problem
'no-async-promise-executor': 'off', // it is convenient sometimes to await in promise executor
Expand Down Expand Up @@ -153,6 +156,8 @@ module.exports.configs = {
'@typescript-eslint/unbound-method': 'off', // unbound methods are often fine
'@typescript-eslint/no-misused-promises': 'off', // disregarding a promise value doesn't mean it is being misused

'no-unused-expressions': 'off', // TS version of rule fixes to support optional chaining
'@typescript-eslint/no-unused-expressions': 'error',
'@typescript-eslint/no-unnecessary-type-arguments': 'error',
'@typescript-eslint/prefer-optional-chain': 'error',
}),
Expand Down

0 comments on commit f212acc

Please sign in to comment.