Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverquotes] [punish] Enabling both breaks serverquotes #56

Closed
Cazed opened this issue May 21, 2018 · 12 comments
Closed

[serverquotes] [punish] Enabling both breaks serverquotes #56

Cazed opened this issue May 21, 2018 · 12 comments
Labels

Comments

@Cazed
Copy link

Cazed commented May 21, 2018

Hi,

I loaded in punish to Red and it breaks serverquotes and won't allow me to load it. Any fix for this?

If you need more information just let me know.

Cazed

@Cazed Cazed changed the title [serverquotes] [punish] [serverquotes] [punish] Enabling both breaks serverquotes May 21, 2018
@calebj
Copy link
Owner

calebj commented May 21, 2018

Make sure your cogs are up to date. It the issue persists, post a screenshot or copy of any errors printed to your console when this happens.

@calebj
Copy link
Owner

calebj commented Jun 3, 2018

I'll close this in a day (at the two week mark) without a reply.

@calebj calebj added the invalid label Jun 13, 2018
@calebj
Copy link
Owner

calebj commented Jun 13, 2018

Closing due to inactivity.

@calebj calebj closed this as completed Jun 13, 2018
@Cazed
Copy link
Author

Cazed commented Jun 27, 2018

Hi,

Sorry for the late reply.

I have updated all my cogs and tried again. First I load punish which loads fine, and then I load serverquotes and it returns this.

File "/root/Red-DiscordBot/cogs/owner.py", line 65, in load
self._load_cog(module)
File "/root/Red-DiscordBot/cogs/owner.py", line 945, in _load_cog
self.bot.load_extension(mod_obj.name)
File "lib/discord/ext/commands/bot.py", line 738, in load_extension
lib.setup(self)
File "/root/Red-DiscordBot/cogs/serverquotes.py", line 258, in setup
n = ServerQuotes(bot)
File "/root/Red-DiscordBot/cogs/serverquotes.py", line 58, in init
self.analytics = CogAnalytics(self)
File "", line 226, in init
File "", line 202, in send_action
File "", line 212, in _gc
File "", line 48, in upgrade
AttributeError: type object 'GVAnalytics' has no attribute 'replace'

If I try and load them in the opposite order, serverquotes loads fine, punish then loads fine but then it unloads serverquotes with nothing showing in the console.

@calebj
Copy link
Owner

calebj commented Jun 27, 2018

You just need to update all of the cogs from my repo. I haven't seen the unloading behavior before, but the code has been set up for a while to ignore things like this while loading. Your version is from before that change.

@Cazed
Copy link
Author

Cazed commented Jun 27, 2018

Hi,

Just ran cog update again, completed with no errors.

I loaded serverquotes first, then loaded punish no problem. As soon as I try and run the !quote command this comes back on the trackback.

File "lib/discord/ext/commands/bot.py", line 252, in _run_extra
yield from coro(*args, **kwargs)
File "/root/Red-DiscordBot/cogs/serverquotes.py", line 240, in on_command
self.analytics.command(ctx)
File "", line 231, in command
File "", line 202, in send_action
File "", line 212, in _gc
File "", line 48, in upgrade
AttributeError: type object 'GVAnalytics' has no attribute 'replace'

@calebj
Copy link
Owner

calebj commented Jun 27, 2018

Did you use the Red portal cog to perform the installation? If so, updates are broken and you will have to mark them all as installed again. This is a bug with the portal cog.

You may also need to restart the bot.

@Cazed
Copy link
Author

Cazed commented Jun 27, 2018

Yes, I used the cog command to add the repo and then install the cog. I done this for both serverquotes and punish.

@Cazed
Copy link
Author

Cazed commented Jun 27, 2018

Just done a restart, same thing.

@calebj
Copy link
Owner

calebj commented Jun 27, 2018

Check my edit; portal cog installation is broken. It's issue orels1/Red-Portal-Cogs#13, the only one open on that repo right now <.>

@Cazed
Copy link
Author

Cazed commented Jun 27, 2018

Could you please advise how I would go about installing these without the portal cog installer?

@calebj
Copy link
Owner

calebj commented Jun 27, 2018

Just install them like any other cog, as if you were installing them for the first time. The downloader won't care if the .py files exist in cogs/ already.

Red-portal should have added the repo as calebj-cogs, so you'll want to do this for each cog you have: [p]cog install calebj-cogs <COGNAME>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants