Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install function erases existing repo data via _repo_add #13

Closed
calebj opened this issue Mar 24, 2018 · 3 comments
Closed

Install function erases existing repo data via _repo_add #13

calebj opened this issue Mar 24, 2018 · 3 comments

Comments

@calebj
Copy link
Contributor

calebj commented Mar 24, 2018

Invoking downloader._repo_add(name, url) on an existing repo clears Installer's data on that repo, causing it to lose track of all installed cogs for purposes of updates. See here.

@orels1
Copy link
Owner

orels1 commented Mar 25, 2018

Thanks for the heads-up. I’ll try to fix that asap

@orels1
Copy link
Owner

orels1 commented Mar 25, 2018

So as I understand it - I should use list_cogs to check if the cog is available. and if so - install it with install or if not - use _repo_add as before

@calebj
Copy link
Contributor Author

calebj commented Mar 25, 2018

Perhaps. Personally, I think that it would be best to invoke the appropriate methods directly instead of going through ctx.invoke. But as long as it checks that it isn't overwriting anything, any approach that works is better than what it does now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants