Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed: Unbind touch event when destroying the tooltip #43

Merged
merged 1 commit into from
Aug 21, 2013
Merged

Bug fixed: Unbind touch event when destroying the tooltip #43

merged 1 commit into from
Aug 21, 2013

Conversation

nirgeier
Copy link
Contributor

@nirgeier nirgeier commented Aug 5, 2013

Fixed touch event bug.

When tooltip is destroyed the touch event was not removed.
Added unbind to touch event to clear it,

The bind is done here:
// if this is a touch device, add some touch events to launch the tooltip
if ((this.options.touchDevices == true) ...) {
$this.bind('touchstart', function(element, options) {
object.showTooltip();
});
}

calebjacob added a commit that referenced this pull request Aug 21, 2013
Bug fixed: Unbind touch event when destroying the tooltip
@calebjacob calebjacob merged commit 8b9e64b into calebjacob:master Aug 21, 2013
@calebjacob
Copy link
Owner

Hey, thanks for pointing that out! Just realized that I'm using .bind() for that when it should be using .on() and .off() for that touchstart event. I'll try and get around to that soon.

@nirgeier nirgeier deleted the Unbind_touch_event_bug_fix branch August 21, 2013 16:48
@nirgeier
Copy link
Contributor Author

Sure.

Its a tiny fix.

Keep up the great work.

On Wed, Aug 21, 2013 at 6:44 PM, Caleb Jacob notifications@github.comwrote:

Hey, thanks for pointing that out! Just realized that I'm using .bind()
for that when it should be using .on() and .off() for that touchstart
event. I'll try and get around to that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants