"Developing in the monorepo" instructions incomplete #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem with the previous startup instructions.
_scripts/build.sh
and friends assume tools in../node_modules/.bin
relative to_scripts
.node_modules/_scripts/build.sh
Lines 7 to 9 in 7706485
Normally
npm install
in a directory that contains apackage.json
will create anode_modules
subdirectory, but not when the current directory is namednode_modules
.Renaming the
node_modules
directory to something else, runningnpm install
, and then changing the directory back does not work becauserequire(...)
will not look for anode_modules
subdirectory inside anode_modules
directory.This happens because of how
require(...)
searches ancestor-ward:The changed setup instructions address the problem by cloning into a different directory name so that there is no
node_modules
path element on "$PWD".