Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - Translate booking status when empty screen #1219

Merged
merged 6 commits into from
Dec 27, 2021

Conversation

arb0z
Copy link
Contributor

@arb0z arb0z commented Nov 26, 2021

Translate booking status parameter for EmptyScreen's messages to be fully i18n

@vercel
Copy link

vercel bot commented Nov 26, 2021

@arb0z is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@PeerRich
Copy link
Member

PeerRich commented Dec 2, 2021

does translations for "status" exist already?

@PeerRich
Copy link
Member

PeerRich commented Dec 7, 2021

this PR misses a "status" key in /en/common.json

this would break if merged

@arb0z
Copy link
Contributor Author

arb0z commented Dec 7, 2021

All "status" values are translated (past, cancelled, upcoming).
I've added "status" key for EN & FR

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this translation!

@PeerRich PeerRich enabled auto-merge (squash) December 27, 2021 12:29
@PeerRich
Copy link
Member

thank you @arb0z – merged 🙏

@PeerRich PeerRich merged commit 1567feb into calcom:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants