-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: select calendars to check for availability #267
Feature: select calendars to check for availability #267
Conversation
Also upgraded outlook integration to be able to check all calendars instead of only the default one.
@Malte-D is attempting to deploy a commit to the calendso Team on Vercel. A member of the Team first needs to authorize it. |
I skipped the creation of a migration for now, because it would create duplicates with https://github.com/calendso/calendso/pull/261. |
I've merged Nico's migrations PR here, so that should resolve the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the .catch() thing on fetch Promises (which I cannot decide alone), the code is fine and you got my approvement. :)
.then((response) => response.json()) | ||
.then(data => { | ||
setSelectableCalendars(data) | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider introducing a global error handler to catch rejected promises and display them to the user / catch and ignore them if that's fine. Or at least use .catch((err) => do whatever you want with err);
somewhere in your Promise chain after fetch(...)
. For now (not a stable version yet), I'd say it's fine as you did it, but I think for the future that would be neat. Or what do you think @baileypumfleet @emrysal @PeerRich?
@emrysal Did you find anything else? |
Implemented calendar selection for availability checking.
Also upgraded outlook integration to be able to check all calendars instead of only the default one.