Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: select calendars to check for availability #267

Conversation

Malte-D
Copy link
Contributor

@Malte-D Malte-D commented Jun 14, 2021

Implemented calendar selection for availability checking.
Also upgraded outlook integration to be able to check all calendars instead of only the default one.

Also upgraded outlook integration to be able to check all calendars instead of only the default one.
@vercel
Copy link

vercel bot commented Jun 14, 2021

@Malte-D is attempting to deploy a commit to the calendso Team on Vercel.

A member of the Team first needs to authorize it.

@Malte-D
Copy link
Contributor Author

Malte-D commented Jun 14, 2021

I skipped the creation of a migration for now, because it would create duplicates with https://github.com/calendso/calendso/pull/261.
After that is merged, the migration can be added here

@baileypumfleet
Copy link
Contributor

I've merged Nico's migrations PR here, so that should resolve the conflict

lib/calendarClient.ts Outdated Show resolved Hide resolved
lib/calendarClient.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Nico-J Nico-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the .catch() thing on fetch Promises (which I cannot decide alone), the code is fine and you got my approvement. :)

.then((response) => response.json())
.then(data => {
setSelectableCalendars(data)
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider introducing a global error handler to catch rejected promises and display them to the user / catch and ignore them if that's fine. Or at least use .catch((err) => do whatever you want with err); somewhere in your Promise chain after fetch(...). For now (not a stable version yet), I'd say it's fine as you did it, but I think for the future that would be neat. Or what do you think @baileypumfleet @emrysal @PeerRich?

@Malte-D
Copy link
Contributor Author

Malte-D commented Jun 18, 2021

@emrysal Did you find anything else?

@baileypumfleet baileypumfleet merged commit 2960463 into calcom:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants