Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The github web page does not tell the user to install the linux-cli BEFORE installing the GUI. #74

Closed
Chummpp opened this issue Jun 1, 2020 · 1 comment · Fixed by #71
Assignees

Comments

@Chummpp
Copy link

Chummpp commented Jun 1, 2020

Describe the bug
After manuall installation the terminal came back with what you see bellow.
Traceback (most recent call last):
File "setup.py", line 6, in
from protonvpn_linux_gui.constants import VERSION
File "/home/dennis/linux-gui/protonvpn_linux_gui/constants.py", line 2, in
from protonvpn_cli.constants import VERSION as cli_version, USER as cli_user
ModuleNotFoundError: No module named 'protonvpn_cli'

To Reproduce
Steps to reproduce the behavior:

  1. Type git clone https://github.com/ProtonVPN/linux-gui
  2. Type cd linux-gui
  3. Type sudo python3 setup.py install
  4. See error

Expected behavior
I expected the GUI to load.

Screenshots
https://postimg.cc/G8vGrMjN, https://i.postimg.cc/Tw49VF5R/Linux-mint-19-protonvpn-GUI.png

Desktop (please complete the following information):

  • OS: [Linux mint 19.3]
@calexandru2018 calexandru2018 changed the title The guthub web page does not tell the user to install the linux-cli BEFORE installing the GUI. The github web page does not tell the user to install the linux-cli BEFORE installing the GUI. Jun 1, 2020
@calexandru2018
Copy link
Owner

calexandru2018 commented Jun 1, 2020

Hi @Chummpp :)

Thank you for creating this issue. This is indeed something that definitely needs to be fixed, thank you for highlighting it!

The idea here is that when you run sudo python3 setup.py install, the CLI should be automatically installed. I will fix this asap!

Edit: I will update manual install instructions. Instead of sudo python3 setup.py install, first install the CLI (sudo pip3 install protonvpn-cli) and then install the GUI, with the following line: sudo pip3 install -e .

calexandru2018 added a commit that referenced this issue Jun 1, 2020
@calexandru2018 calexandru2018 self-assigned this Jun 1, 2020
@kaplun kaplun closed this as completed in #71 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants