-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the UNAVAILABLE certificate. #115
Add the UNAVAILABLE certificate. #115
Conversation
Hey, We have talked about it in the morning, but honestly, I don't feel comfortable with approving this. As an example, we have also added other (regular) sustainability labels and these wouldn't be part of this branch. In other words, what speaks against merging the main branch into this one? Maybe @se-jaeger can have a look at this and say if there might be any implications. |
Hi, I didn't add any documentation as I didn't know that that was a requirement for every MR. But for this small of a change I thought making this MR was a step enough to make everyone aware that we need to update the special labels file - and as added in the json change itself there is a description in German already of why that label is needed.
I think the new labels should be added in this (test-database-with-new-poetry) branch as well, as if I'm not mistaken, they won't pass the Also, regarding why are we using that branch, I haven't seen any comment left on that anywhere, and I don't know if it's safe to merge the main branch in it, but when trying to switch to the main branch in the dependencies section once, I got the following message:
... So, that's why I assumed there are some dependency issues, and that's why I continued adding my changes on that branch. |
I think it would be much nicer to fix this one #94 and use this repos' main branch for the ecosia-exporter as dependency. |
Thanks for the prompt reply @se-jaeger ! |
Thanks for the feedback in the DM Alex, I also misunderstood your point in the first place. |
No description provided.