docs: clarify the docs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoh
requested review from
benschwarz and
thefoxis
and removed request for
benschwarz
benschwarz
requested changes
Jan 16, 2020
There was a problem hiding this comment.
Thanks for your contribution @steveoh. There's a few details that will require some change before being merged but I think there are some solid improvements here. Great stuff! 🥰
Co-Authored-By: Ben Schwarz <ben@calibreapp.com>
Co-Authored-By: Ben Schwarz <ben@calibreapp.com>
Co-Authored-By: Ben Schwarz <ben@calibreapp.com>
benschwarz
reviewed
Jan 17, 2020
Co-Authored-By: Ben Schwarz <ben@calibreapp.com>
benschwarz
reviewed
Jan 17, 2020
benschwarz
reviewed
Jan 17, 2020
benschwarz
reviewed
Jan 17, 2020
benschwarz
reviewed
Jan 17, 2020
benschwarz
requested changes
Jan 17, 2020
Co-Authored-By: Ben Schwarz <ben@calibreapp.com>
|
Great contribution, thanks so much @steveoh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a warning that my configuration was out dated. When I read the docs about how to update, I was a little confused and it took a few more more runs to get it right. This pr aims to fix that and a few other things. I think it reads better and I hope you do too.