Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add class attribute to wrapping element #184

Merged
merged 3 commits into from Oct 11, 2022
Merged

✨ Add class attribute to wrapping element #184

merged 3 commits into from Oct 11, 2022

Conversation

robmorieson
Copy link
Contributor

What does this PR introduce?

  • Provider components now accept a containerClass prop allowing a custom class to be added to the div element that wraps the placeholder icon. If no prop is provided the fallback class of live-chat-loader-placeholder is added.
  • Update the README.md to include the details above. Also edited some of the existing language to make it more explicit that styling props apply to the placeholder element, not the actual widget loaded by the provided.

closes #92

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-live-chat-loader ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 5:09AM (UTC)

@robmorieson robmorieson marked this pull request as ready for review October 7, 2022 05:26
benschwarz
benschwarz approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@benschwarz benschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robmorieson robmorieson changed the title Styling ✨ Add class attribute to wrapping element Oct 11, 2022
@robmorieson robmorieson merged commit 05a13ea into main Oct 11, 2022
@robmorieson robmorieson deleted the styling branch October 11, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benschwarz benschwarz benschwarz approved these changes

@thefoxis thefoxis thefoxis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Ability to style components
3 participants
@robmorieson @benschwarz @thefoxis