-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Emojis and automation #1
Conversation
As the UUID always changes, it generates a lot of noise 🤷♂
Hey @stefanzweifel, thanks for the awesome changes! The build process is definitely going to help keep this up to date! I also think it's a good idea to remove the unzipped pack. I thought this would make diffing easier but it hadn't occurred to me that the UUID would change. On closer inspection of the original pack, it looks like there are a few differences and I think we should keep it consistent for the existing user base. These changes were made to make the pack easier to use.
Do you think it would be possible to:
Thanks! |
Thanks for the fast response. While working on this PR I discovered that the emoji keywords differed from your original snippet pack. I thought I just give it a try, but totally forgot that it would break the workflow from existing users. To your points:
Based on this data
So 1., 3. and 4. are pretty easy. 2nd point will need some time… |
Contains all Snippets from the Original Version
Created a json file with the differences in keywords between the original snippets pack and the new version
I figured out a way to get the differences between your original Emoji Pack and the new version. I've generated this file which contains a diff of the emojis. Instead of picking, which old emoji keyword/name we should keep, I would suggest that we just keep all of them. I've added a script which would patch these old emojis in. This file is now responsible of building the archive. You can download a patched build here: Let me know if you have further questions. |
@stefanzweifel this is amazing work. Is the best way to keep this up to date moving forward just rebuilding locally every time gemoji releases an update? |
@califa Yeah I think so. You could add a service like dependabot to automatically retrieve PRs to be notified if a dependency updates and then create a new build. |
Great work! I'll update the download link and blog post shortly :) |
Don't forget to rebuild the snippets file and push it to the repo. |
Running the build will do that right? |
Just to be clear, the patch is what's adding the new emojis? |
The patch is for adding the emojis which differ from I'm updating my local fork and push a new PR, to make it a bit more clear |
Hey there 👋
This PR adds a node build command to the project, to hopefully automate the creation of the snippets-file with new emojis in the future.
The bulk of the emojis and their shortcodes are build from the gemoji node package, which itself depends on the gemoji ruby gem maintained by GitHub itself.
As there's still a PR open in the upstream github/gemoji repository to add emojis from the 2017 release, I've added a handful of emojis myself (See
otherSnippetsAndEmojis.js
).Other stuff that has changed in comparison to
master
:emoji-pack-unzipped
folder. Everytime a new build is created, there would be thousand of changes, as the UUID changes. Don't know if this okay or if this should be added back in 🤷♂️Emoji Pack.alfredsnippets
which can be downloaded and used in Alfred is committed to the repoLet me know if something is unclear or something should be changed. Happy to help.