Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form type choices #105

Merged
merged 4 commits into from
Mar 3, 2015
Merged

form type choices #105

merged 4 commits into from
Mar 3, 2015

Conversation

JoeGermuska
Copy link
Contributor

Is this what you had in mind for #98, #99, #100 ? If so, I can carry on with #86, #87, #88, #89, #90, #91, #92, #93, #94, #95, #96

@JoeGermuska
Copy link
Contributor Author

The __unicode__ methods are gravy, but they seemed straightforward and helped my eyes from glazing over looking at the admin tool to make sure things were basically working. I figured safest to only use non-null fields, although at a glance, filer names, dates and such might be more attractive.

@palewire
Copy link
Owner

palewire commented Mar 3, 2015

Yes. That's the kind of thing we're after, though our prissy PEP8 validator doesn't like the line lengths (no biggie) so the TravisCI test is failing.

If you want to mow through them all that's great. I can always come up with more tickets!

@palewire palewire merged commit 00c1b4c into palewire:master Mar 3, 2015
@JoeGermuska
Copy link
Contributor Author

the day slipped away, so we'll see. It's also the case that now that a model is set they are super easy for newbs to pick up.

@palewire
Copy link
Owner

palewire commented Mar 3, 2015

Cool. Thanks man. You're on the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants