Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive crash #24

Closed
iwasrobbed opened this issue May 5, 2014 · 9 comments
Closed

Recursive crash #24

iwasrobbed opened this issue May 5, 2014 · 9 comments

Comments

@iwasrobbed
Copy link
Contributor

It appears there is a scenario where infinite recursion can occur when the underlying view controller is JDStatusBarNotificationViewController:

https://github.com/jaydee3/JDStatusBarNotification/blob/master/JDStatusBarNotification/JDStatusBarNotification.m#L506

- (BOOL)shouldAutorotate {
    return [[self keyWindowRootViewController] shouldAutorotate];
}

Full crash log for you: https://gist.github.com/iwasrobbed/9d1cf7ddc96413023d7c

@calimarkus
Copy link
Owner

uh good to know. will have a look at this tomorrow. do you have a sample project, where this happens?

@iwasrobbed
Copy link
Contributor Author

Unfortunately I could not reproduce it (nor have I seen it during extensive use/testing), but I received that via Crashlytics. We actually don't allow rotation at all within our app and we only show the notification view in place of a UIAlertView when there is no internet access.

Sorry I couldn't be of more help, I just wanted to open an issue in case others received similar crashes.

@calimarkus
Copy link
Owner

is your app in the App Store?

@iwasrobbed
Copy link
Contributor Author

It is indeed (2.0 is a bit buggy, but 2.0.1 will be out in a few days). http://www.everest.com

@calimarkus
Copy link
Owner

cool, how often did the crash occur? only once? I can't imagine how the status bar window became the key window..

@iwasrobbed
Copy link
Contributor Author

It's only ever occurred once for one user, so I think it's fairly rare.

@calimarkus
Copy link
Owner

thanks anyway. its fixed in the new pod version.

@iwasrobbed
Copy link
Contributor Author

Thanks!

@victorengel
Copy link

Still seeing this issue -- anyone else? I found this issue because there is a comment in the code:
// find another window, if our window is the key window (should fix #24)

So I'm using the "fixed" version.

I have not been able to reproduce the problem at will, but it has been reported a few times by the test team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants