Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Implement server-side download hash computing #44

Closed
Calinou opened this issue Nov 26, 2019 · 3 comments
Closed

Implement server-side download hash computing #44

Calinou opened this issue Nov 26, 2019 · 3 comments

Comments

@Calinou
Copy link
Owner

Calinou commented Nov 26, 2019

The server should compute the SHA-256 checksum of all version downloads (both if the link is inferred from the version tag or custom). It should then be persisted to the database.

This hash could also be displayed with small text on asset detail pages.

@Calinou Calinou self-assigned this Nov 26, 2019
@Calinou
Copy link
Owner Author

Calinou commented Jan 6, 2020

Note that a workaround was implemented in 8ac10f9, so the API should still be functional for now.

That said, consider this comment:

/**
 * [...]
 * TODO: Consider computing the download hash on a per-version basis and store it.
 *       However, this may not be a good idea as GitHub ZIP hashes aren't guaranteed
 *       to be the same over a long period of time.
 */

@bojidar-bg
Copy link
Collaborator

As hashes were removed in the official asset library (currently replaced by using exact commit hashes when specifying a download link), I suppose this can be closed?

@Calinou
Copy link
Owner Author

Calinou commented May 16, 2020

@bojidar-bg Indeed, thanks for the reminder 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants