-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined from http request #44
Comments
Can you show your CLI and tsconfig? |
Have you tested this with v6? |
Closing due to no response. If this issue persists, please open a new issue. |
I’ll be spinning up a new project with v6, but intercom integration wants be until September. Let you know. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug
Angular Version = 5.2.1
Angular CLI Version = 1.7.4
Node & NPM Version = 5.8.0
When loading the app at localhost and booting intercom widget, http request returns undifind from the request to 'https://widget.intercom.io/widget/undifined'.
I've traced this back to ng-intercom.js at:
Intercom.prototype.l = function () { var d = document; var s = d.createElement('script'); s.type = 'text/javascript'; s.async = true; s.src = "https://widget.intercom.io/widget/" + this.id; var x = d.getElementsByTagName('script')[0]; x.parentNode.insertBefore(s, x); };
as this.id is not a known variable of the function call this.l it returns undifined and should be:
Intercom.prototype.l = function (config) { var d = document; this.id = config.appId; var s = d.createElement('script'); s.type = 'text/javascript'; s.async = true; s.src = "https://widget.intercom.io/widget/" + this.id; var x = d.getElementsByTagName('script')[0]; x.parentNode.insertBefore(s, x); };
,than used as 'this.l(config);'
The text was updated successfully, but these errors were encountered: