Merge pull request mozilla#15820 from calixteman/fix_visual_order

The annotation layer dimensions must be set before adding some elements (follow-up of mozilla#15770)

src/display/annotation_layer.js

@@ -2585,6 +2585,7 @@ class AnnotationLayer {
    */
   static render(parameters) {
     const { annotations, div, viewport, accessibilityManager } = parameters;
+    setLayerDimensions(div, viewport);
 
     let zIndex = 0;
 
@@ -2652,7 +2653,6 @@ class AnnotationLayer {
     }
 
     this.#setAnnotationCanvasMap(div, parameters.annotationCanvasMap);
-    setLayerDimensions(div, viewport);
   }
 
   /**
@@ -2664,9 +2664,9 @@ class AnnotationLayer {
    */
   static update(parameters) {
     const { annotationCanvasMap, div, viewport } = parameters;
+    setLayerDimensions(div, { rotation: viewport.rotation });
 
     this.#setAnnotationCanvasMap(div, annotationCanvasMap);
-    setLayerDimensions(div, { rotation: viewport.rotation });
     div.hidden = false;
   }
 

test/integration/accessibility_spec.js

@@ -106,4 +106,37 @@ describe("accessibility", () => {
       );
     });
   });
+
+  describe("Annotations order", () => {
+    let pages;
+
+    beforeAll(async () => {
+      pages = await loadAndWait("fields_order.pdf", ".annotationLayer");
+    });
+
+    afterAll(async () => {
+      await closePages(pages);
+    });
+
+    it("must check that the text fields are in the visual order", async () => {
+      await Promise.all(
+        pages.map(async ([browserName, page]) => {
+          const ids = await page.evaluate(() => {
+            const elements = document.querySelectorAll(
+              ".annotationLayer .textWidgetAnnotation"
+            );
+            const results = [];
+            for (const element of elements) {
+              results.push(element.getAttribute("data-annotation-id"));
+            }
+            return results;
+          });
+
+          expect(ids)
+            .withContext(`In ${browserName}`)
+            .toEqual(["32R", "30R", "31R", "34R", "29R", "33R"]);
+        })
+      );
+    });
+  });
 });

test/pdfs/.gitignore

@@ -560,3 +560,4 @@
 !issue15759.pdf
 !issue15753.pdf
 !issue15789.pdf
+!fields_order.pdf