Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version checks between local and remote projects #46

Closed
ckoerber opened this issue Jan 30, 2020 · 2 comments
Closed

Version checks between local and remote projects #46

ckoerber opened this issue Jan 30, 2020 · 2 comments

Comments

@ckoerber
Copy link
Member

ckoerber commented Jan 30, 2020

In the scenario where a user communicates with a central database running different table definitions (different migration histories), it might happen that intermediate objects are inserted before the user code crashes.

This can be prevented by running checks on the import of EspressoDB (the init() function).
Things to cross check are:

(1) The version of EspressoDB
(2) The version of the EspressoDB project if applicable
(3) The migration history

The execution of checks should be optional to allow rapid development--nevertheless, this information should be on a prominent doc page.

  • The migration history check can be realized by the default mechanics of makemigrations.
  • EspressoDB and EspressoDB project versions must be inserted in the database when migrations are applied. This can be done by adding new default version tables and overloading the manage.py migrate command. On import (and if required) EspressoDB tries to read the most recent information and fails if versions disagree.

Update related to the JOSS review process raised by @remram44.

openjournals/joss-reviews#2007

@ckoerber ckoerber moved this from To do to In progress in v1.1.0 [JOSS Review Updates] Feb 5, 2020
ckoerber pushed a commit that referenced this issue Feb 5, 2020
This addresses #46.
Options for enabling checks and tests need to be added.
@ckoerber
Copy link
Member Author

ckoerber commented Feb 6, 2020

For this issue, the code development takes place on the feature-init-checks branch.

@ckoerber
Copy link
Member Author

Closed with #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant