Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react v15.4.0: React tap event plugin dep #5573

Closed
tthamel opened this issue Nov 16, 2016 · 10 comments · Fixed by #5580
Closed

react v15.4.0: React tap event plugin dep #5573

tthamel opened this issue Nov 16, 2016 · 10 comments · Fixed by #5580
Labels
docs Improvements or additions to the documentation

Comments

@tthamel
Copy link

tthamel commented Nov 16, 2016

update to react tap event version 2 breaks as this requires version 1

@sfncook
Copy link

sfncook commented Nov 16, 2016

... and the update to react tap event version 2 is required due to breaking changes released with react version 15.4.0 as of this morning. :( zilverline/react-tap-event-plugin#85

@tthamel
Copy link
Author

tthamel commented Nov 16, 2016

is there an update to material UI as well?

@tthamel
Copy link
Author

tthamel commented Nov 16, 2016

to clarify when i try to update the react-tap to version 2 material complains about version 1 being needed, its fine to update on my local but in build environments it pulls from the repo and still wants to see 1

@sfncook
Copy link

sfncook commented Nov 16, 2016

@tthamel I think that's what the "issue" is. Material-UI is now essentially broken if you want to use React v 15.4.0 I don't know of a workaround or fix other than downgrading react-* packages. :( If someone has a better idea, I'd love to hear it. This little snafu is killing my day.

@dano-giftbit
Copy link

@tthamel Until this is sorted I've had to manually install version15.3.0 of react and any peer dependencies

@tthamel
Copy link
Author

tthamel commented Nov 16, 2016

we use 15.0.0 so i would think we wouldn't be affected by 15.4 but when it trys to build material ui fails on react-tap 1 and then i point the devdeps to react-tap 2 material ui complains about react tap 1 not being there... yeah think alot of devs got a swift kick in the junk this morning :/

@sfncook
Copy link

sfncook commented Nov 16, 2016

my junk was definitely assulted

@oliviertassinari
Copy link
Member

#5572 should be addressing this issue. It would be great to release ASAP now.

@oliviertassinari oliviertassinari changed the title React tap event plugin dep react v15.4.0: React tap event plugin dep Nov 16, 2016
@pontiyaraja
Copy link

I think this one will help you guys.

zilverline/react-tap-event-plugin#82

@q42jaap
Copy link

q42jaap commented Nov 17, 2016

npm WARNs about missing pear dependency, but npm install does not exit with a non-zero status code, so having react-tap-event-plugin@2.0.0 will just work (their API did not change).

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants