Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Ability to influence maxDialogContentHeight #6885

Closed
RohovDmytro opened this issue May 17, 2017 · 2 comments
Closed

[Dialog] Ability to influence maxDialogContentHeight #6885

RohovDmytro opened this issue May 17, 2017 · 2 comments
Labels
component: dialog This is the name of the generic UI component, not the React module!

Comments

@RohovDmytro
Copy link

Specifically, I am talking about this line:

https://github.com/callemall/material-ui/blob/master/src/Dialog/Dialog.js#L227

I am done with making full screen dialog with version 0.18.1, but this line holds be from free feature autoScrollBodyContent = true. If there was a way to influence on those magic numbers — it would be great.

Does it make sense to discuss before 1.0 release?

@RohovDmytro RohovDmytro changed the title [Dialog] Change max available height calculation [Dialog] Ability in influence to maxDialogContentHeight May 17, 2017
@RohovDmytro RohovDmytro changed the title [Dialog] Ability in influence to maxDialogContentHeight [Dialog] Ability to influence maxDialogContentHeight May 17, 2017
@RohovDmytro
Copy link
Author

The easiest way I see is to expose one more public property — maxDialogContentHeight and do not calculated in internally if it is passed.

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label May 19, 2017
@oliviertassinari
Copy link
Member

We have been porting the component on the next branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants