[CircularProgress] Add "inherit" color option #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: CircularProgress
|
Can you update the TypeScript definition too?
No, it's automatic. I do it from time to time with |
oliviertassinari
approved these changes
Oct 27, 2017
|
@dapetcu21 Perfect, thank you! |
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
* [CircularProgress] Add "inherit" color option * [CircularProgress] Update TypeScript defs to include inherit color * [CircularProgress] Update API docs
oliviertassinari
added
the
component: progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most other components that accept a
coloracceptinherit, I figured why not add this toCircularProgressas well.My use case is a white progress indicator on a dark background, which I can achieve with
<CircularProgress style={{ color: 'inherit' }} />, butcolor='inherit'is more in-line with the other components.I have no idea how to update the docs in
pages/api, though. Should I update them manually?