Remove sorting on attrdict key nesting #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 95.85% 95.86% +0.01%
==========================================
Files 24 24
Lines 3619 3629 +10
Branches 788 724 -64
==========================================
+ Hits 3469 3479 +10
Misses 86 86
Partials 64 64
|
sjpfenninger
previously approved these changes
Feb 28, 2024
CHANGELOG.md
Outdated
|
|
||
| |new| `py.typed` file so that mypy recognises Calliope as a typed library when it is imported as a dependency. | ||
|
|
||
| |changed| GitHub action versions updated: `codecov/codecov-action` -> v4, `actions/checkout` -> v4, `dawidd6/action-download-artifact` -> v3. |
There was a problem hiding this comment.
Do we want CI changes in the changelog? We didn't in the past, but I realise some CI-related changes have been there since 0.7.0.dev2
There was a problem hiding this comment.
Maybe we don't, you're right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576
Summary of changes in this pull request:
Reviewer checklist: