Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin hdf5 and h5py in all xarray environments #357

Conversation

sjpfenninger
Copy link
Member

@sjpfenninger sjpfenninger commented Apr 12, 2024

This is pulling out the fix from #317 (commit 7b6bcf3) to resolve errors importing xarray on linux-x86, given that it seems #317 might not be merged any time soon.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

@sjpfenninger
Copy link
Member Author

In the meantime it seems that the fix perhaps does not work consistently, but we can still use this PR to track the required change, if further fixes are needed.

@sjpfenninger
Copy link
Member Author

Upon further testing, libnetcdf=4.7 seems to make things work in #354. @irm-codebase Can you check and confirm?

@sjpfenninger sjpfenninger marked this pull request as ready for review April 12, 2024 13:08
Copy link
Member

@timtroendle timtroendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a tiny documentation issue looks good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
@timtroendle timtroendle merged commit e5410ac into calliope-project:develop Apr 15, 2024
4 checks passed
@sjpfenninger sjpfenninger deleted the feature-fix-xarray-import-on-linux branch April 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants