Update zenodo source of gridded weather data #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
timtroendle
approved these changes
Jun 7, 2024
config/schema.yaml
Outdated
| pattern: ^(https?|http?):\/\/.+ | ||
| description: "Web address of gridded 10m wind speed data. Expecting a netCDF file with the coordinates [time, site], and the variables [temperature, lat, lon]." | ||
| pattern: ^(https?|http?):\/\/.+{data_var}.*\.(nc)$ | ||
| description: "Web address of gridded weather data. Expecting a netCDF file with the coordinates [time, site], the variables [{data_type}, lat, lon], and the attribute 'unit'." |
There was a problem hiding this comment.
Should be [{data_var}, lat, lon] I guess?
| @@ -218,17 +222,14 @@ def get_daily_heat_demand( | |||
|
|
|||
| def heat_function(t, parameters): | |||
There was a problem hiding this comment.
Type hints are missing everywhere but I understand they will be added in #390.
There was a problem hiding this comment.
Yes, and better variable naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some review comments from @irm-codebase in #390.
Made a specific PR as they are changes that are worth considering in isolation, I believe. Deals with data units, mostly.
I'll deal with the rest of the review comments in #390 directly.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.