Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shared coast ID #23

Merged
merged 1 commit into from
May 14, 2021
Merged

Update shared coast ID #23

merged 1 commit into from
May 14, 2021

Conversation

brynpickering
Copy link
Member

Fixes #22

@brynpickering brynpickering mentioned this pull request May 13, 2021
Merged
timtroendle
timtroendle approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@timtroendle timtroendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where the id comes from in the first place and what it represents. The raw data does not contain it and so it must be introduced by one of the fiona commands in rule eez_in_europe .

@brynpickering
Copy link
Member Author

Yeah, it's the GeoJSON Feature IDs, which are purely internal structure definitions.

@brynpickering brynpickering merged commit a170000 into main May 14, 2021
@brynpickering brynpickering deleted the fix-shared-coast-id branch May 14, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtroendle timtroendle timtroendle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update shared coast IDs to EEZ MRGID
2 participants
@brynpickering @timtroendle