Splitting Profile in separate components for accessibility snapshot testing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarNestorov
force-pushed
the
chore/multiple-snapshots
branch
from
9bc1188
to
c6f04bd
Compare
DimitarNestorov
commented
Apr 19, 2023
|
|
||
| function ProfilePicture({picture = tomProfilePicture}: {picture?: string}) { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
Fragments were used in order to have a simpler diff
DimitarNestorov
force-pushed
the
chore/multiple-snapshots
branch
from
c6f04bd
to
ba103d2
Compare
A `SnapshotTest` native module was created to register every component from the JavaScript thread instead of having to modify Swift files every time
DimitarNestorov
force-pushed
the
chore/multiple-snapshots
branch
from
ba103d2
to
d9f7b7c
Compare
DimitarNestorov
commented
May 7, 2023
| for item in items { | ||
| let expectation = expectation(description: "Wait for content to appear") | ||
| let observer = Observer(expectation) | ||
| let profileView = RCTRootView(frame: .init(x: 0, y: 0, width: 300, height: 700), |
There was a problem hiding this comment.
Suggested change
| let profileView = RCTRootView(frame: .init(x: 0, y: 0, width: 300, height: 700), | |
| let view = RCTRootView(frame: .init(x: 0, y: 0, width: 300, height: 700), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
SnapshotTestnative module was created to register every component from the JavaScript thread instead of having to modify Swift files every timeThe new snapshots: