Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript #252

Merged
merged 1 commit into from
Sep 6, 2022
Merged

chore: update typescript #252

merged 1 commit into from
Sep 6, 2022

Conversation

mdjastrzebski
Copy link
Member

Summary

Update typescript plugins versions as current version of the config still warns about unsupported TS version 5.8.2.

Test plan

All checks pass.

@thymikee thymikee merged commit c7fafc6 into main Sep 6, 2022
@thymikee thymikee deleted the chore/update-typescript branch September 6, 2022 10:05
@@ -39,7 +39,7 @@
},
"devDependencies": {
"eslint": "^8.1.0",
"typescript": "^4.8.0"
"typescript": "^4.8.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change version range to be patch version or even fixed version? TS does not follow SemVer, so going from 4.8 to 4.9 may include unexpected breaking changes.

Suggested change
"typescript": "^4.8.2"
"typescript": "~4.8.2"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dev dependency, so I wouldn't bother. It's locked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants