chore: bump flow to 0.57.2 (#252)

* chore: bump flow to 0.56.0

* Update snapshots

* simplify Promise<any> type

* Extract CollectOptions and CollectOutput

* Bump flow to 0.57.2

.flowconfig

@@ -1,5 +1,5 @@
 [version]
-0.42.0
+0.57.2
 
 [ignore]
 .*/example

jest/helpers.js

@@ -9,7 +9,8 @@
 
 const traverse = require('traverse'); // eslint-disable-line import/no-extraneous-dependencies
 
-const flushPromises = () => new Promise(resolve => setTimeout(resolve));
+const flushPromises = (): Promise<any> =>
+  new Promise(resolve => setTimeout(resolve));
 
 const replacePathsInObject = (object: mixed) => {
   return traverse(object).map(

package.json

@@ -7,7 +7,7 @@
   },
   "scripts": {
     "precommit": "lint-staged",
-    "flow": "flow",
+    "flow": "flow --include-warnings",
     "lint": "eslint .",
     "jest": "jest",
     "test": "npm run flow && npm run lint && npm run jest",
@@ -76,7 +76,7 @@
     "babel-preset-react-native": "^2.0.0",
     "eslint": "^4.3.0",
     "eslint-config-callstack-io": "^0.3.1",
-    "flow-bin": "^0.42.0",
+    "flow-bin": "^0.57.2",
     "husky": "^0.13.3",
     "jest": "test",
     "lint-staged": "^3.4.0",

src/commands/bundle.js

@@ -4,6 +4,8 @@
  *
  * @flow
  */
+import type { Command } from '../types';
+
 const path = require('path');
 const webpack = require('webpack');
 const clear = require('clear');
@@ -83,7 +85,7 @@ async function bundle(opts: *) {
   );
 }
 
-module.exports = {
+module.exports = ({
   name: 'bundle',
   description: 'Builds the app bundle for packaging',
   action: bundle,
@@ -150,4 +152,4 @@ module.exports = {
       default: 'webpack.haul.js',
     },
   ],
-};
+}: Command);

src/commands/init.js

@@ -4,6 +4,7 @@
  *
  * @flow
  */
+import type { Command } from '../types';
 
 const path = require('path');
 const fs = require('fs');
@@ -318,8 +319,8 @@ const addToXcodeBuild = async (cwd: string) => {
   }
 };
 
-module.exports = {
+module.exports = ({
   name: 'init',
   description: 'Generates necessary configuration files',
   action: init,
-};
+}: Command);

src/commands/reload.js

@@ -4,6 +4,7 @@
  *
  * @flow
  */
+import type { Command } from '../types';
 
 const clear = require('clear');
 const logger = require('../logger');
@@ -40,9 +41,9 @@ async function reload() {
   req.end();
 }
 
-module.exports = {
+module.exports = ({
   name: 'reload',
   description: 'Sends reload request to all devices that enabled live reload',
   action: reload,
   options: [],
-};
+}: Command);

src/commands/start.js

@@ -4,6 +4,8 @@
  *
  * @flow
  */
+import type { Command } from '../types';
+
 const webpack = require('webpack');
 const path = require('path');
 const clear = require('clear');
@@ -122,7 +124,7 @@ async function start(opts: *) {
   ).listen(opts.port);
 }
 
-module.exports = {
+module.exports = ({
   name: 'start',
   description: 'Starts a new webpack server',
   action: start,
@@ -191,4 +193,4 @@ module.exports = {
       default: 'webpack.haul.js',
     },
   ],
-};
+}: Command);

src/hot/client/hotApi.js

@@ -1,7 +1,7 @@
 /**
  * Copyright 2017-present, Callstack.
  * All rights reserved.
- * 
+ *
  * @flow
  */
 
@@ -17,24 +17,25 @@ import resetRedBox from './utils';
 
 const instances = {};
 
+type State = {
+  error: ?Object,
+};
+
 /**
  * Wrap root component factory with custom HotWrapper, which allows for deep force update
  * and servers as an error boundry.
  */
 export function makeHot(initialRootFactory: Function, id?: string = 'default') {
   return () => {
-    class HotWrapper extends Component {
-      state: {
-        error: ?Object,
+    class HotWrapper extends Component<*, State> {
+      state = {
+        error: null,
       };
 
       rootComponentFactory: ?Function;
 
       constructor(props: *) {
         super(props);
-        this.state = {
-          error: null,
-        };
         instances[id] = this;
         this.rootComponentFactory = null;
       }
@@ -126,7 +127,7 @@ export function callOnce(callback: Function) {
 
 /**
  * Clear specified module cache. The module must be a resolved with `require.resolve`.
- * 
+ *
  */
 export function clearCacheFor(resolvedModuleName: string) {
   delete require.cache[resolvedModuleName];

src/hot/client/hotPatch.js

@@ -1,7 +1,7 @@
 /**
  * Copyright 2017-present, Callstack.
  * All rights reserved.
- * 
+ *
  * @flow
  */
 
@@ -55,7 +55,6 @@ if (typeof global.__REACT_HOT_LOADER__ !== 'undefined') {
       typeof id === 'string' && /react-native/.test(id)
         ? _createElement
         : patchedCreateElement;
-    // $FlowFixMe
     return fn(type, ...args);
   };
 

src/loaders/assetLoader.js

@@ -28,7 +28,12 @@ module.exports = async function assetLoader() {
 
   const query = utils.getOptions(this) || {};
   const options = this.options[query.config] || {};
-  const config: Config = Object.assign({}, options, query);
+  const config: Config = Object.assign(
+    {},
+    { platform: 'ios', root: process.cwd() },
+    options,
+    query,
+  );
 
   const pathSepPattern = new RegExp(`\\${path.sep}`, 'g');
   const filepath = this.resourcePath;

src/resolvers/AssetResolver.js

@@ -17,6 +17,19 @@ type Options = {
   platform: 'ios' | 'android',
 };
 
+type CollectOutput = {
+  [key: string]: {
+    platform: 'ios' | 'android',
+    name: string,
+  },
+};
+
+type CollectOptions = {
+  name: string,
+  platform: string,
+  type: string,
+};
+
 function AssetResolver(options: Options) {
   const platform = options.platform;
   const test = options.test || AssetResolver.test;
@@ -83,9 +96,9 @@ function AssetResolver(options: Options) {
 
 AssetResolver.test = /\.(bmp|gif|jpg|jpeg|png|psd|svg|webp|m4v|aac|aiff|caf|m4a|mp3|wav|html|pdf)$/;
 AssetResolver.collect = (
-  list,
-  { name, type, platform }: { name: string, type: string, platform: string },
-) => {
+  list: Array<string>,
+  { name, type, platform }: CollectOptions,
+): CollectOutput => {
   const regex = /^(bmp|gif|jpg|jpeg|png|psd|tiff|webp|svg)$/.test(type)
     ? new RegExp(
         `^${escapeStringRegexp(

src/server/middleware/rawBodyMiddleware.js

@@ -4,7 +4,7 @@
  *
  * @flow
  */
-function rawBodyMiddleware(req: *, res: *, next: *) {
+function rawBodyMiddleware(req: any, res: *, next: *) {
   req.rawBody = '';
   req.setEncoding('utf8');
 

src/types.js

@@ -7,18 +7,18 @@
  * @flow
  */
 
-export type CommandArgs = Array<string>;
+type Choice = {
+  value: string | boolean | number,
+  description: string,
+};
 
 export type CommandOption = {
   name: string,
   description: string,
-  parse?: (val: string) => mixed,
-  default?: mixed | ((opts: { [key: string]: string }) => mixed),
+  parse?: Function,
+  default?: any,
   example?: string,
-  choices?: Array<{
-    value: mixed,
-    description: string,
-  }>,
+  choices?: Array<Choice>,
 };
 
 export type Command = {

src/utils/__tests__/__snapshots__/getBabelConfig.test.js.snap

@@ -2,7 +2,6 @@
 
 exports[`creates new config when no .babelrc found 1`] = `
 Object {
-  "babelrc": false,
   "plugins": Array [
     "<<REPLACED>>/utils/fixRequireIssues.js",
     "<<NODE_MODULE>>/react-hot-loader/babel.js",
@@ -16,7 +15,6 @@ Object {
 
 exports[`does not include "hot" plugins in production 1`] = `
 Object {
-  "babelrc": false,
   "plugins": Array [
     "<<REPLACED>>/utils/fixRequireIssues.js",
   ],