feat(build): when build fails -> print an error with a stacktrace (#269)

callstack · Nov 2, 2017 · ccdaf20 · ccdaf20 · Titozzz · Nov 7, 2017
1 parent 03e63f6
commit ccdaf20
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 3 deletions.
diff --git a/src/commands/bundle.js b/src/commands/bundle.js
@@ -66,7 +66,15 @@ async function bundle(opts: *) {
   const stats = await new Promise((resolve, reject) =>
     compiler.run((err, info) => {
       if (err || info.hasErrors()) {
-        reject(new MessageError(messages.bundleFailed()));
+        reject(
+          new MessageError(
+            messages.bundleFailed({
+              errors: err
+                ? [err.message]
+                : info.toJson({ errorDetails: true }).errors,
+            })
+          )
+        );
       } else {
         resolve(info);
       }

diff --git a/src/commands/start.js b/src/commands/start.js
@@ -111,7 +111,11 @@ async function start(opts: *) {
     stats => {
       clear();
       if (stats.hasErrors()) {
-        logger.error(messages.bundleFailed());
+        logger.error(
+          messages.bundleFailed({
+            errors: stats.toJson({ errorDetails: true }).errors,
+          })
+        );
       } else {
         logger.done(
           messages.bundleBuilt({

diff --git a/src/messages/bundleFailed.js b/src/messages/bundleFailed.js
@@ -4,5 +4,12 @@
  *
  * @flow
  */
+const dedent = require('dedent');
 
-module.exports = () => 'Failed to compile';
+module.exports = ({ errors }: { errors: string[] }) => {
+  return dedent`
+    Failed to compile.
+ 
+${errors.join('\n\n')}
+  `;
+};
diff --git a/src/server/index.js b/src/server/index.js
@@ -49,6 +49,10 @@ function createServer(
     lazy: false,
     noInfo: true,
     reporter: null,
+    /**
+     * Quiet the default errors, we will handle error by our own
+     */
+    quiet: true,
     stats: 'errors-only',
     hot: true,
     mimeTypes: { 'application/javascript': ['bundle'] },