New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bundle files without "index" in the name #358
Conversation
With this approach, Also, do you use HMR in project?? |
Oh you're right this is incomplete, I totally left out the protocol! I was running into red screen errors, failing on this line of the polyfillEnvironment file, even though I hadn't turned on HMR. If there's a way to somehow opt out of this file getting run when I don't need HMR that would be a fine workaround for our project. |
@Traviskn don't forget to rebase before you start working on that, we recently added a fix to this part of the codebase |
You can move into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this against master?
Yes I'll rebase on master |
fe1b4ef
to
2620db1
Compare
2620db1
to
9661076
Compare
While rebasing I noticed that the latest changes to the |
We have a project where we have more entry-points in addition to the
index.js
, but these other entry-point files don't haveindex
in their name. (If you're curious about the use-case for this, it's because we are using react-native-threads.This PR is a different strategy for finding the dev server origin without looking specifically for
index
. I'm very open to feedback on this approach or if anyone has a better idea for going about it.