Update polyfills to sync with latest RN #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
|
Hold on for now, I didn't apply some of my changes |
thymikee
commented
Apr 24, 2018
| // | ||
| if (!global.self) { | ||
| global.self = global; /* eslint-disable-line */ | ||
| } |
There was a problem hiding this comment.
We now inject self as a banner, as with Webpack 4 upgrade we seem to need to act on it earlier
|
This is ready for review now |
satya164
approved these changes
Apr 24, 2018
jukben
reviewed
Apr 25, 2018
| } | ||
| ErrorUtils.applyWithGuard(fun, context, args); |
|
@thymikee I will run the tests ASAP. I will get back to you then! Thank you for finish this off. 🙏 |
zamotany
previously requested changes
Apr 26, 2018
| "webpack-dev-middleware": "^1.12.0", | ||
| "webpack-hot-middleware": "^2.19.1", | ||
| "webpack": "^4.6.0", | ||
| "webpack-hot-middleware": "^2.22.1", |
There was a problem hiding this comment.
Wut?? We don't use it anymore.
There was a problem hiding this comment.
Actually we do, for process-update:
haul/src/hot/client/hotClient.js
Line 9 in 95ade60
thymikee
dismissed
zamotany’s stale review
we use process-update from webpack-hot-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #410 (thanks @jukben), but without the breaking changes.
We decided to not introduce breakage (apart from new config, which is breaking gracefully) for now. We can however update the polyfills, which simplifies a bit our BannerPlugin usage.
I've tested
example-applinked with yarn on both iOS and Android with live reload and HMR.