Fix android debugging not working when window.location is a file:// URL

[hedgepigdaniel]

See #405

I'm not sure if this will break something else (or what the intention is when using window.location), but for me, this allows debugging to work with react-native-debugger and android with haul 1.0.0-rc.5.

[zamotany]

AFAIK this will break remote debugging on Android

[hedgepigdaniel]

Interesting - for me remote debugging on android is broken without this change.

Perhaps the issue is that I'm connecting to the debugger over a real network connection, rather than an ADB reversed port on localhost - I'll try with a USB cord and see what happens - perhaps there is a way to make it work in both cases.

[hedgepigdaniel]

I've tested with both of these situations:

• an ADB connection to the device over USB with adb reverse tcp:8081 tcp:8081, and the app configured with the "Dev server host and port for device" to localhost:8081
• an ADB connection to the device over a network and the app configured with the "Dev server host and port for device" to <ip of machine running haul + rn debugger>:8081

In both of these cases, the app crashes when remote debugging is switched on as detailed in #405. In both cases with this patch, it works correctly.

Other details I am testing with

• React Native Debugger: 0.7.18
• OS: Arch Linux
• React Native: 0.54.4
• Device: Nexus 6P Android 8.1.0

Not sure what else about the environment might vary such that it works/doesn't work the other way around?

[hedgepigdaniel]

I should add that all these tests are done with HMR switched on - Since the crash happens when trying to connect the HMR socket, I think everything is fine in all cases unless you turn on HMR.

[hedgepigdaniel]

OK how about this - it checks whether window.location.protocol is file: (It is, in my case), and only in that case it skips using window.location to set DEV_SERVER_ORIGIN.

In other cases where window.location is the network location of the debug server, this should now not break debugging.

[thymikee]

Thanks you @hedgepigdaniel