fix: re-exports compiled by tsc not working #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
getOwnPropertyDescriptor
method of the exports proxy seems to be incorrect causingexport *
compiled to commonjs by the typescript compiler to not work.Typescript will compile
export *
to the following:Because
getOwnPropertyDescriptor
always return an object thehasOwnProperty
call will always returntrue
causing no exports to get added.Here is a cut down example of this causing issues when using linaria together with @fluentui/react https://stackblitz.com/edit/linaria-bug-nl1c3w
Summary
The only change made in this PR is to only return a property descriptor when the export exist.
Test plan
I added a test that tests verifies that
export *
compiled to commonjs by tsc works. The test fails without my change but works with it.