Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper ordering of collected CSS #114

Merged
merged 1 commit into from Sep 22, 2017
Merged

fix: Proper ordering of collected CSS #114

merged 1 commit into from Sep 22, 2017

Conversation

thymikee
Copy link
Member

Summary

The css from collect function in SSR favored @rules before normal ones, which resulted in broken CSS order.

Test plan

Fixed tests (also running them through prettier for readability)

@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #114 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   97.65%   97.38%   -0.28%     
==========================================
  Files          18       18              
  Lines         341      344       +3     
  Branches       59       60       +1     
==========================================
+ Hits          333      335       +2     
- Misses          8        9       +1
Impacted Files Coverage Δ
src/server/collect.js 97.5% <100%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c61aa4...84d50ac. Read the comment docs.

@satya164 satya164 self-assigned this Sep 22, 2017
@satya164 satya164 merged commit 1923b45 into master Sep 22, 2017
@satya164 satya164 deleted the fix/collect-order branch September 22, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants