Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup SSR for website #117

Merged
merged 14 commits into from Oct 4, 2017
Merged

feat: Setup SSR for website #117

merged 14 commits into from Oct 4, 2017

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Sep 22, 2017

Summary

Adds server rendering with critical CSS to the website.
Fixes #29

TODO:

  • setup working SSR
  • update server rendering docs
  • improve express server (gzip, svg handling, etc)

Test plan

tbd

* @flow
*/

export default function escapeHtml(unsafe: string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a package for this on npm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno, I usually do it by hand

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          19       19           
  Lines         370      370           
  Branches       66       66           
=======================================
  Hits          361      361           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d7c80...ee998c0. Read the comment docs.

@thymikee
Copy link
Member Author

@satya164 ready for review.

@thymikee thymikee changed the title [WIP] feat: Setup SSR for website feat: Setup SSR for website Oct 4, 2017
@thymikee thymikee merged commit 42403a3 into master Oct 4, 2017
@thymikee thymikee deleted the feat/ssr branch October 4, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants