fix(babel-preset,shaker): do not delete exported functions even if its body was deleted #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1a3609 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Anber
force-pushed
the
issue/1226
branch
2 times, most recently
from
ffbcb34
to
1068f58
Compare
…s body was deleted
chentsulin
reviewed
Jul 4, 2023
| /* remove */testFn = arg | ||
| ) | ||
|
|
||
| export default function testDefaultFn(arg) { |
There was a problem hiding this comment.
Hi @Anber, is this export default function got accidentally deleted? Is this correct?
exports[`removeWithRelated should not remove top-level functions with empty bodies 1`] = `
"function testFn() {}
export const testArrow1 = () => {};
const testArrow2 = () => {};"
`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Linaria currently has a bug that leads to the deletion of exported functions from some modules when their body contains restricted code, such as JSX, React hooks, or browser API. (see #1226)
Summary
This pull request addresses the aforementioned bug by replacing the problematic functions with an empty one instead of deleting them. By doing so, we preserve the exported functions while effectively neutralizing the restricted code within them. This approach maintains the original structure of the module exports without causing any unexpected side effects or errors.