Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split integration tests for speed #144

Merged
merged 3 commits into from Oct 20, 2017
Merged

Conversation

thymikee
Copy link
Member

Summary

shaves off 2x time when running integration tests

Test plan

Tests: 36 passed, 36 total
Snapshots: 37 passed, 37 total

@codecov
Copy link

codecov bot commented Oct 19, 2017

Codecov Report

Merging #144 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage    97.5%   97.51%   +0.01%     
==========================================
  Files          19       20       +1     
  Lines         401      403       +2     
  Branches       74       75       +1     
==========================================
+ Hits          391      393       +2     
  Misses         10       10
Impacted Files Coverage Δ
setupJest.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b09e7...55023dc. Read the comment docs.

setupJest.js Outdated
.toString()
.replace(
new RegExp(escapeStringRegexp(process.cwd()), 'gm'),
'<<REPLACED>>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about CWD??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll replace it, good call

@zamotany zamotany merged commit 632c1fb into master Oct 20, 2017
@zamotany zamotany deleted the chore/split-tests branch October 20, 2017 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants