feat: support template literals in object properties and jsx props #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/properties
branch
3 times, most recently
from
451f7fe
to
59ed07a
Compare
satya164
force-pushed
the
@satya164/properties
branch
3 times, most recently
from
782a0d5
to
8ce4330
Compare
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 97.57% 97.51% -0.06%
==========================================
Files 20 19 -1
Lines 412 403 -9
Branches 80 81 +1
==========================================
- Hits 402 393 -9
Misses 10 10
Continue to review full report at Codecov.
|
zamotany
suggested changes
Oct 21, 2017
| title = parent.node.name.name; | ||
| } else { | ||
| title = parent.node.key.name; | ||
| } |
There was a problem hiding this comment.
You should generate unique id after this line, otherwise the following will generate the same classnames:
const a = { header: css`...` }
const b = { header: css`...` }
// or
<article className={css`...`} />
<div>
<article className={css`...`} />
</div>Maybe title = path.scope.generateUidIdentifier(title).name.
There was a problem hiding this comment.
This will become a major problem if we settle on using filename in production also (#147).
There was a problem hiding this comment.
@zamotany will the unique id be consistent across builds?
satya164
force-pushed
the
@satya164/properties
branch
8 times, most recently
from
1c65755
to
549ef20
Compare
satya164
force-pushed
the
@satya164/properties
branch
from
549ef20
to
487dd78
Compare
zamotany
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #134, #138