Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): properly process configFile if provided #342

Closed
wants to merge 3 commits into from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Mar 7, 2019

Summary

while configFile cli was implemented it doesn't work (#336).

This PR makes it work (processes the actual config file if present).

Before:
image

After:

image

Btw using flow was really a PITA from a contributor experience 馃憖馃

@callstack-bot
Copy link

callstack-bot commented Mar 7, 2019

Hey @Hotell, thank you for your pull request 馃.
The coverage report for this branch can be viewed here.

src/cli.js Outdated Show resolved Hide resolved
@satya164
Copy link
Member

satya164 commented Mar 7, 2019

Btw using flow was really a PITA from a contributor experience

We want to migrate to typescript, but it'll take time.

@Hotell
Copy link
Contributor Author

Hotell commented Mar 7, 2019

changes applied. Please re-review. cheers

satya164 added a commit that referenced this pull request Mar 7, 2019
satya164 pushed a commit that referenced this pull request Mar 7, 2019
satya164 pushed a commit that referenced this pull request Mar 7, 2019
zamotany pushed a commit that referenced this pull request Mar 8, 2019
@satya164
Copy link
Member

satya164 commented Mar 8, 2019

Refactored and merged in 5265b69

@satya164 satya164 closed this Mar 8, 2019
@Hotell
Copy link
Contributor Author

Hotell commented Mar 8, 2019

I really appreciate this project and your help, but this is not very nice behavior to your contributors. Not at all.

You should explicitly say next time that you'll do it on your own, rather than leaving someone else spent his free time on something which is gonna be tossed away. Not cool at all.

@satya164
Copy link
Member

satya164 commented Mar 8, 2019

@Hotell I had some time so I thought instead of requesting more changes to your PR, I can finish it quicker and do a release. I didn't have write access to your branch, so I created a new branch based on your PR. I also gave attribution to you in my commit. The attribution was mistakenly lost on master because it was squashed instead of "rebase and merge" during merging.

I'm sorry this upset you, but it wasn't my intention.

satya164 pushed a commit that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants