New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): properly process configFile if provided #342
Conversation
We want to migrate to typescript, but it'll take time. |
changes applied. Please re-review. cheers |
Refactored and merged in 5265b69 |
I really appreciate this project and your help, but this is not very nice behavior to your contributors. Not at all. You should explicitly say next time that you'll do it on your own, rather than leaving someone else spent his free time on something which is gonna be tossed away. Not cool at all. |
@Hotell I had some time so I thought instead of requesting more changes to your PR, I can finish it quicker and do a release. I didn't have write access to your branch, so I created a new branch based on your PR. I also gave attribution to you in my commit. The attribution was mistakenly lost on master because it was squashed instead of "rebase and merge" during merging. I'm sorry this upset you, but it wasn't my intention. |
Summary
while configFile cli was implemented it doesn't work (#336).
This PR makes it work (processes the actual config file if present).
Before:
After: